-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: remove :
from protocol in Url.parse().
#1237
Conversation
What is the purpose of this? |
If there is always a |
I move we just close this. It breaks all code ever written against the url module, including the test suite, for no good reason. |
Previously: nodejs/node-v0.x-archive#1580 Current behavior matches the browser: (new URL('https://github.com/iojs/io.js/pull/1237')).protocol
// => 'https:' |
Might as well keep it like the browser. |
KenanY, bnoordhuis |
@aino please read nodejs/node-v0.x-archive#1580 |
:) Thanks guys. |
I only removed
:
from parsed protocol.